Formatting fixes #120
Formatting fixes #120
Conversation
| """ | ||
|
|
||
| def broadcast_parameters(self): | ||
| def broadcast_parameters(self) -> None: |
There was a problem hiding this comment.
i personally dont like the -> None type inting anywhere, it feels redundant.
There was a problem hiding this comment.
@Mayankm96 Whats your opinion on this? :D
| def reset( | ||
| self, | ||
| dones: torch.Tensor | None = None, | ||
| hidden_states: tuple[torch.Tensor | tuple[torch.Tensor, ...] | None, ...] = (None, None), |
There was a problem hiding this comment.
this is such an ugly type 😅
It would feel pretty confusing to me if i were using it for the first time. Either we define a HiddenState type in the memory.py or we need to add some docstrings. I would personally prefer the first one
There was a problem hiding this comment.
Mh, I get it, but I am personally not a big fan of defining types. But maybe it still makes sense for this one.
| old_mu_batch = old_mu[batch_idx] | ||
| old_sigma_batch = old_sigma[batch_idx] | ||
|
|
||
| hid_a_batch = None |
There was a problem hiding this comment.
does creating this None variables inside the loop add some non negligeble overhead? Probably not right
There was a problem hiding this comment.
I would doubt that. Should be fine :)
2 participants
Validated on the following tasks: