Skip to content

Julian/feature/ros2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
386e4f6
add ros2 pkgs
deepanaishtaweera May 19, 2025
8d37404
temporaliy edit cmakelist and package xml
deepanaishtaweera May 19, 2025
66d4f1f
noetic docker setup
nubertj May 20, 2025
c9ae4bc
first non running version of graph_msf_catkin
nubertj May 20, 2025
734373c
Add initial implementation of smb_estimator_graph_ros2 package
deepanaishtaweera May 21, 2025
9aa32bc
Update CMakeLists.txt to reference the correct constants header for s…
deepanaishtaweera May 21, 2025
04be004
Refactor includes to use smb_estimator_graph_ros2 namespace for consi…
deepanaishtaweera May 21, 2025
57fa16a
Refactor SmbEstimator and SmbStaticTransforms classes to use ROS 2 co…
deepanaishtaweera May 21, 2025
d71d18f
Update CMakeLists.txt to include GTSAM package and clean up dependenc…
deepanaishtaweera May 22, 2025
8c428cd
Fix CMakeLists.txt to use project name variable in target_link_librar…
deepanaishtaweera May 22, 2025
138ccc2
Refactor SmbStaticTransforms constructor to remove dependency on Stat…
deepanaishtaweera May 22, 2025
91e3579
Replace XML launch files with Python launch files for smb_estimator_g…
deepanaishtaweera May 23, 2025
2e0899b
Refactor remove_map_and_odom_from_bag.py to utilize rosbag2 API for r…
deepanaishtaweera May 23, 2025
c9690b0
Enhance error handling and logging in remove_tf_from_bag.py
deepanaishtaweera May 23, 2025
6b464ff
Enhance plotting functionality and logging in plot_latest_quantitites…
deepanaishtaweera May 23, 2025
54d0caf
Add new parameters for marginals computation and alignment in readPar…
deepanaishtaweera May 23, 2025
a30c404
Refactor setup.py to use setuptools, adding package metadata and entr…
deepanaishtaweera May 23, 2025
432352b
Refactor manual_pose_files_to_tf_and_odom_bag.py to improve file proc…
deepanaishtaweera May 23, 2025
8534dea
Update package name in smb_estimator_graph.launch.py to smb_estimator…
deepanaishtaweera May 23, 2025
4b78b8d
Enhance CMakeLists.txt by adding GTSAM_UNSTABLE package
deepanaishtaweera May 23, 2025
b2f85c8
Add export section to package.xml for launch file configuration
deepanaishtaweera May 23, 2025
3a01e90
Add export for include directories in CMakeLists.txt to improve packa…
deepanaishtaweera May 23, 2025
79a1f81
Update parameter declarations in GraphMsfRos2.cpp to include new sett…
deepanaishtaweera May 23, 2025
3c94970
Update parameter names and add new logging options in GraphMsfRos2 se…
deepanaishtaweera May 23, 2025
c56e615
Refactor YAML configuration files for smb_estimator_node to include p…
deepanaishtaweera May 23, 2025
3438fd2
Add launch file for smb_estimator_graph_ros2 to configure simulation …
deepanaishtaweera May 23, 2025
6ff2d25
Update IMU frame parameter in core_extrinsic_params.yaml from 'imu' t…
deepanaishtaweera May 23, 2025
7429b29
first almost compiling version, just issue with one symbol and libmetis
nubertj May 23, 2025
320cf14
running version, full separation of graph msf and build system
nubertj May 26, 2025
a2d69fc
moving of examples inside ros and ros2 folders
nubertj May 26, 2025
7962bb8
fix two more examples, now full graph_msf_ros_examples meta package i…
nubertj May 27, 2025
ff6cd78
make sure the gtsam libaries can be found
nubertj May 27, 2025
442c3f9
update to holistic_fusion
nubertj May 27, 2025
60c3abb
merged in ros2 stuff, but not yet compiling
nubertj May 27, 2025
2d0b24f
building with colcon without any ament specific package in graph_msf …
nubertj May 27, 2025
d96dd77
remove unnecessary ament dependency messing up catkin build
nubertj May 27, 2025
195f993
merge in main
nubertj May 27, 2025
fd4022c
merged in main
nubertj Jun 11, 2025
8852bd0
Merge remote-tracking branch 'origin/main' into julian/feature/ros2
nubertj Jun 11, 2025
105bfd3
Julian/feature/ros2 fixes (#12)
nubertj Jun 11, 2025
c8c118a
new ros2 setup
nubertj Jun 11, 2025
a2257df
running version
nubertj Jun 11, 2025
0a48aa1
added use_sim_time and debugging
nubertj Jun 11, 2025
60616e0
more efficeint and path vis
nubertj Jun 15, 2025
d162e98
fixing of bug and better visualization
nubertj Jun 16, 2025
de562e4
bit more tuning
nubertj Jun 16, 2025
3bf4c80
Update IMU and Lidar odometry topic names in launch file for improved…
deepanaishtaweera Jun 19, 2025
e3c5c42
Make graph msf compatible with Open3D SLAM instead of DLIO
tutunarsl Jun 19, 2025
d1ab159
latest updates
nubertj Jun 19, 2025
366c468
latest update with outlier filtering and offline optimization service
nubertj Jun 19, 2025
781149d
fixed ordering of param reading and flag setting for static tfs
willat343 Jun 20, 2025
6c8180c
Merge pull request #14 from leggedrobotics/will/fix/smb_ros2
willat343 Jun 20, 2025
748c0f1
Update lidar odometry topic name in smb_estimatior_launch file
Jun 20, 2025
6ecfe00
added more checks to IMU
willat343 Jun 21, 2025
ef1e346
cleaned up IMU checks, added more (disabled) time checks
willat343 Jun 21, 2025
b3e10a0
Fix graph_msf_ros2 not found error
deepanaishtaweera Jun 22, 2025
fb95ae8
increased time window for angular velocity in LocalVelocity3 factor
willat343 Jun 23, 2025
a3220cc
changed topic names
willat343 Jun 23, 2025
7bb7913
fixed wheel velocity by removing robust loss, tuning noise values
willat343 Jun 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions graph_msf/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,11 @@ message("CMAKE_BUILD_INCLUDE_DIR: ${CMAKE_BUILD_INCLUDE_DIR}")
find_package(Eigen3 REQUIRED)
find_package(GTSAM REQUIRED)
find_package(GTSAM_UNSTABLE REQUIRED)
find_package(Python3 REQUIRED COMPONENTS Development)
find_package(tf2_eigen REQUIRED)

message("Eigen Version:: ${EIGEN3_VERSION_STRING}")
message("Eigen Path:: ${EIGEN3_DIR}")
message("GTSAM Include Path:: ${GTSAM_INCLUDE_DIRS}")

set(CMAKE_POSITION_INDEPENDENT_CODE ON)

# Color settings for terminal output
if(NOT WIN32)
string(ASCII 27 Esc)
Expand All @@ -41,17 +37,10 @@ if(NOT WIN32)
set(Magenta "${Esc}[35m")
endif ()

# Eigen
find_package(Eigen3 REQUIRED COMPONENTS)
# GTSAM
find_package(GTSAM REQUIRED)
find_package(GTSAM_UNSTABLE REQUIRED)
message("GTSAM Version:" ${GTSAM_VERSION})
message("GTSAM Path:" ${GTSAM_DIR})

###########
## Build ##
###########

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

Expand All @@ -76,6 +65,8 @@ add_library(${PROJECT_NAME} SHARED
src/lib/TrajectoryAlignmentHandler.cpp
src/lib/NavState.cpp
)
# Exported alias target
add_library(${PROJECT_NAME}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})

# Link GTSAM and other dependencies to the graph_msf library
target_link_libraries(${PROJECT_NAME}
Expand Down
2 changes: 1 addition & 1 deletion graph_msf/include/graph_msf/config/StaticTransforms.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class StaticTransforms : public TransformsDictionary<Eigen::Isometry3d> {
const std::string& getInitializationFrame() { return initializationFrame_; }

// Functionality ------------------------------------------------------------
virtual void findTransformations() = 0;
virtual bool findTransformations() = 0;

protected:
// Required frames
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ class GmsfUnaryExpressionLocalVelocity3 final : public GmsfUnaryExpressionLocal<
// Check whether we can find an IMU measurement corresponding to the velocity measurement
double imuTimestamp;
graph_msf::ImuMeasurement imuMeasurement = graph_msf::ImuMeasurement();
if (!imuBufferPtr->getClosestImuMeasurement(imuTimestamp, imuMeasurement, 0.02, velocityUnaryMeasurementPtr->timeK())) {
REGULAR_COUT << RED_START << "No IMU Measurement (in time interval) found, assuming 0 angular velocity for the factor." << COLOR_END
if (!imuBufferPtr->getClosestImuMeasurement(imuTimestamp, imuMeasurement, 0.1, velocityUnaryMeasurementPtr->timeK())) { // previously 0.02
REGULAR_COUT << RED_START << " No IMU Measurement (in time interval) found, assuming 0 angular velocity for the factor." << COLOR_END
<< std::endl;
}

Expand Down

This file was deleted.

Loading