Add user profile field functionality.#4
Add user profile field functionality.#4troywilliams wants to merge 3 commits intolearningworks:masterfrom
Conversation
noisyjerm
left a comment
noisyjerm
left a comment
There was a problem hiding this comment.
Code looks good. A couple of questions added as comments.
UI works as expected, no errors displayed.
In field configuration, these options are disabled. Is that deliberate?
- Display in the summary report
- Display in the learner instance report
- Display to learner
classes/local/item_type_list.php
Outdated
| //new measures\assignment_resubmit_count(), | ||
| new measures\assignment_status(), | ||
| new measures\attendance_sessions_summary(), | ||
| new measures\checklist_complete(), | ||
| //new measures\checklist_complete(), | ||
| new measures\course_grade(), | ||
| new measures\course_section_activity_completion(), | ||
| new measures\grade_category_activity_completion(), | ||
| //new measures\grade_category_activity_completion(), |
There was a problem hiding this comment.
Why have these measures been commented out?
There was a problem hiding this comment.
Forgot about those. I will restore/uncomment. This is possibly something for the future. Create a plugin setting/config var to store enabled measures. LW doesn't use those measures, sometimes I click on Assignment resubmit count rather than Assignment status. Needs a UI Improvement.
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function get_data_for_users(user_list $userlist): array |
There was a problem hiding this comment.
Where is get_data_for_users() used? Does it need to be added before release?
There was a problem hiding this comment.
I don't think so, but I wil sort.
|
@noisyjerm Should be all gravy now. |
2 participants
Adds the ability to add a user profile field to the LPR.
Config
Report
