Skip to content

Text updates - mainly readme.md #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zpottie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Text updates - mainly readme.md #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions KNOWNISSUES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Responsiveness of grid items at lower screen resolutions
Responsiveness of list items at >800px
Some default responsiveness behaviour
2 changes: 1 addition & 1 deletion locallib.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ function block_lw_courses_get_sorted_courses($showallcourses = false) {
break;
}

// Make sure user is still enroled.
// Make sure user is still enrolled.
Copy link

@emyb emyb May 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Make sure user is still enrolled.
// Make sure the user is still enrolled.

if (isset($courses[$cid])) {
$sortedcourses[$cid] = $courses[$cid];
$counter++;
Expand Down
16 changes: 8 additions & 8 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,33 @@
[![Code Climate](https://codeclimate.com/github/learningworks/moodle-block_lw_courses/badges/gpa.svg)](https://codeclimate.com/github/learningworks/moodle-block_lw_courses/)
[![Issue Count](https://lima.codeclimate.com/github/learningworks/moodle-block_lw_courses/badges/issue_count.svg)](https://lima.codeclimate.com/github/learningworks/moodle-block_lw_courses)

Installation Instruction
=====================
Installation Instructions
=========================

* Make sure you have all the required versions.
* Download and unpack the block folder.
* Place the folder (eg "lw_courses") in the "blocks" subdirectory.
* Visit http://yoursite.com/admin to complete the installation
* Turn editing on the my page.
* Turn editing on the /my page.
* Add the block to the page
* Visit the config link in the block for more options.
* Navigate to the block's admin settings for various custom settings

Moodle compatibility
=====================
Moodle Compatibility
====================
* Tested with Moodle 3.0, 3.1 and 3.2

Features
====================
* Unique dashboard for learners and teachers
* Two layouts to choose from
* Show's leraner's progress in a course from their home page
* Shows learner's progress in a course from their home page

![List styling](https://github.com/learningworks/moodle-block_lw_courses/raw/master/pix/list.png "List styling")
![Grid styling](https://github.com/learningworks/moodle-block_lw_courses/raw/master/pix/grid.png "Grid styling")

Change log
=====================
Please Look in CHANGELOG
Please look in CHANGELOG
Copy link

@emyb emyb May 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please look in CHANGELOG
Please look in CHANGELOG.


About Author
=====================
Expand Down
2 changes: 1 addition & 1 deletion renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ public function course_image_defaults() {
$image = html_writer::empty_tag('img', array( 'src' => $imageurl, 'class' => 'course_image' ));
return html_writer::div($image, 'image_wrap');
} else {
// We need a CSS soloution apparently lets give it to em.
// We need a CSS solution apparently lets give it to 'em.
Copy link

@emyb emyb May 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// We need a CSS solution apparently lets give it to 'em.
// We need a CSS solution apparently. Lets give it to 'em.

Or X gon' give it to ya.

return html_writer::div('', 'course_image_embed',
array("style" => 'background-image:url('.$imageurl.'); background-size:cover'));
}
Expand Down