-
Notifications
You must be signed in to change notification settings - Fork 243
[Remove Vuetify from Studio] Channel details in Channels - page layout #5510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
[Remove Vuetify from Studio] Channel details in Channels - page layout #5510
Conversation
…siveModal in ChannelDetailsModal
…ructure and styling
|
Hii @MisRob,question about layout: Using
Let me know your preference! Thanks! |
|
Hi @vtushar06, I think it'd be meaningful to remove In this way, we will be able to use Note that there are few other places where |
… structure; enhance ChannelDetailsModal tests for better clarity and functionality
16caaa3 to
3ced5cf
Compare
…proved visibility
1453e81 to
c2a3e42
Compare
|
Hi @MisRob, |
|
I wanted to confirm the intended behavior: I’ve added |
|
@vtushar06 we won't do any changes to user experience unless explicitly mentioned in the issue - it's not the goal of this project, and we have internal processes that would need to precede such decisions. So please stay as close as possible to the current experience. |
|
okay sure @MisRob, I thought in sake for UX, reverting back the changes to use current experience, thanks for this guidance too. |
3ccd761 to
5437d8a
Compare
|
Hii @MisRob, I have updated inner page to use previous codes, I think now you can review this out whenever possible and let me know if any further changes required to update. |
|
Thanks for you understanding @vtushar06 - it's definitely good that you think about how to improve user experience - I just need to work within the scope of this project ;) |
Summary
Migrates
ChannelDetailsModalfrom Vuetify to Kolibri Design System by creating a newStudioImmersiveModalcomponent.Changes:
StudioImmersiveModal.vue- Fullscreen modal using KToolbar and KIconButton (no Vuetify dependencies)ChannelDetailsModal.vue:FullscreenModalwithStudioImmersiveModalKButton+KDropdownMenuLoadingTextwithStudioLargeLoaderDetailsPanelunchanged per requirementsScreenshots:
References
Closes: #5474
…
Reviewer guidance
Quick Test:
pnpm install && pnpm run devserver:hot[email protected]/aKey Test Cases:
pnpm run devserver)