Skip to content

fix: redirect unauthenticated users from My Channels to public catalog #5488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
+11 −7
Open

fix: redirect unauthenticated users from My Channels to public catalog #5488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7dd8b35
Explore without an account link directly redirecting to public and my…
Abhishek-Punhani Oct 21, 2025
3e3492f
Consolidate authentication redirect logic for unauthenticated users o…
Abhishek-Punhani Oct 28, 2025
3959ffc
Adding Suggested Changes
Abhishek-Punhani Oct 30, 2025
00f03e9
Added route.replace
Abhishek-Punhani Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contentcuration/contentcuration/frontend/accounts/pages/AccountsMain.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<VDivider />
<p class="mt-4 text-xs-center">
<KButton
href="/channels"
href="/channels/#public"
:text="$tr('guestModeLink')"
appearance="basic-link"
/>
Expand Down
16 changes: 10 additions & 6 deletions contentcuration/contentcuration/frontend/channelList/views/ChannelListIndex.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,10 @@
},
watch: {
$route(route) {
if (this.loggedIn && route.name === RouteNames.CHANNELS_EDITABLE) {
this.loadInvitationList();
if (route.name === RouteNames.CHANNELS_EDITABLE) {
this.loggedIn
? this.loadInvitationList()
: this.$router.replace({ name: RouteNames.CATALOG_ITEMS });
}
if (this.fullPageError) {
this.$store.dispatch('errors/clearError');
Expand All @@ -250,10 +252,12 @@
created() {
if (this.loggedIn) {
this.loadInvitationList();
} else if (!CATALOG_PAGES.includes(this.$route.name)) {
this.$router.push({
name: RouteNames.CATALOG_ITEMS,
});
} else {
if (this.$route.name === RouteNames.CHANNELS_EDITABLE) {
this.$router.replace({ name: RouteNames.CATALOG_ITEMS });
} else if (!CATALOG_PAGES.includes(this.$route.name)) {
Copy link
Member

@bjester bjester Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CATALOG_PAGES, which is defined in this file, does not include RouteNames.CHANNELS_EDITABLE.

As I alluded to before, the this.$router.push does not fit with the expected behavior in the issue. So given what CATALOG_PAGES contains, this can be reduced to only changing push to replace

Copy link
Contributor Author

@Abhishek-Punhani Abhishek-Punhani Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CATALOG_PAGES, which is defined in this file, does not include RouteNames.CHANNELS_EDITABLE.

As I alluded to before, the this.$router.push does not fit with the expected behavior in the issue. So given what CATALOG_PAGES contains, this can be reduced to only changing push to replace

@bjester , I have added route.replace there as well.

Copy link
Member

@bjester bjester Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing it to replace.

Now, given what I said previously about CATALOG_PAGES, how are the if-statement conditions different? It seems to me !CATALOG_PAGES.includes(this.$route.name) is true at the same time as this.$route.name === RouteNames.CHANNELS_EDITABLE is true

this.$router.replace({ name: RouteNames.CATALOG_ITEMS });
}
}
},
mounted() {
Expand Down