Adds defensive check when generating language text in the language dr… #5465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolson
added
bug
P1 - important
akolson
added
P2 - normal
bjester
reviewed
Oct 10, 2025
| languageText(item) { | ||
| const firstNativeName = item.native_name.split(',')[0].trim(); | ||
| const nativeName = item?.native_name || ''; | ||
| const firstNativeName = nativeName.split(',')[0].trim(); |
There was a problem hiding this comment.
I think similarly to the node title defensive check, we should be trying to understand why this is happening and whether it's indicative of another issue. I imported shared/leUtils/Languages.js in a Node REPL and all of them had a native_name.
> Array.from(LanguagesMap.values()).filter(l => !l.native_name)
[]
Also, in the Studio database, all languages have it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…opdown
Summary
This pr adds a defensive on the code for the error reported in sentry as detailed here
References
Fixes #5434
Reviewer guidance