-
Notifications
You must be signed in to change notification settings - Fork 232
[Remove Vuetify from Studio] Delete, restore, and visibility confirmation dialogs in admin channel actions #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Prashant-thakur77
wants to merge
14
commits into
learningequality:unstable
Choose a base branch
from
Prashant-thakur77:replace-vuetify-admin-channel-dialogs-5410
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−92
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3b3b02e
Replaced ConfirmationDialog to KModal and added respectively and add…
Prashant-thakur77 14233c6
Made title bold
Prashant-thakur77 cc07735
Removed important as everything works fine without it too
Prashant-thakur77 731d502
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 6f46332
Updated unit test for channelActionsDropdown
Prashant-thakur77 2d117c8
Updated channelActionsDropdown.spec.js for KModal considerations
Prashant-thakur77 5b0b3ac
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 8bce653
Removed div and applied class directly to <p> tag
Prashant-thakur77 0ab1d4c
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] 4be353f
to resolve hard coded color issue with content in kmodal used style k…
Prashant-thakur77 a63c856
Updated accordingly
Prashant-thakur77 bd0584e
Updated test for channel Action dropdown
Prashant-thakur77 e8da954
updated multiple Kmodals into one and used dialog config to maintain …
Prashant-thakur77 97c8260
Removed i18 as per instruction to keep administration as an exception…
Prashant-thakur77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we passing strings like this again ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the feedback on this comment #5426 (comment)
, i was advised to use direct strings in the administration section, and i18n is not required here