Skip to content

[Remove Vuetify from Studio] Page layout in Settings #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

AadarshM07
Copy link
Contributor

Summary

  • Created a component shared/views/StudioPage that has no Vuetify dependencies, and used it instead of VContent and VContainer in SettingsIndex.vue.
  • Ensured UI consistency to match the previous layout. Followed all necessary instructions regarding layout mentioned in the guidelines.

screenshots

image image image

References

Closes #5132

Reviewer guidance

  • I’ve added an offline prop to pass the offline state so appropriate top margin can be applied when the site is offline. This is a slight change from the example usage mentioned in the issue. If this approach isn’t necessary and another method is preferred, please let me know and I’ll update it accordingly.

@MisRob MisRob self-requested a review August 13, 2025 02:58
@MisRob MisRob self-assigned this Aug 13, 2025
@MisRob
Copy link
Member

MisRob commented Aug 14, 2025

Thanks @AadarshM07, I will review next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Page layout in Settings
2 participants