[Remove Vuetify from Studio] Invitations in Channels #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
changed the title
MisRob
reviewed
Aug 6, 2025
| > | ||
| {{ $tr('decline') }} | ||
| </VBtn> | ||
| <template #actions> |
There was a problem hiding this comment.
Just a note that KModal has submitText and cancelText props and internal logic to take care of positioning and styling buttons, so #actions slot in this case shouldn't be needed.
|
Thanks for another contribution @yeshwanth235, I see you put lots of care into it, much appreciated. We will assign a reviewer next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added new StudioRiasedBox
Updated ChannelListIndex.vue with kds components.
Updated MessageDialog with KModal component
Cleaned up vuetify components.
Added unit test cases
video:
https://drive.google.com/file/d/1b_tpyAkcRdNVddef8kAO2rTo1yi5v5qm/view?usp=drive_link
References
5217
Reviewer guidance
Test invitation component. In both web and mweb
Test in both rtl and ltr.
Test accept and decline of the invitation.