Skip to content

Conversation

@gerardopar
Copy link
Collaborator

@gerardopar gerardopar commented Dec 19, 2025

Overview

🎟 Relevant Jira Issues

LC-1497

📚 What is the context and goal of this PR?

This PR adds an empty placeholder when no ai-insights are available, encouraging users to build their LearnCard to unlock personalized learning insights.

🥴 TL; RL:

💡 Feature Breakdown (screenshots & videos encouraged!)

Screenshot 2025-12-19 at 11 20 40 AM

🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

  1. Verify empty state appears when no insights exist

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📝 Documentation Checklist

User-Facing Docs (docs/docs.learncard.com)

  • Tutorial — New capability that users need to learn (docs/tutorials/)
  • How-To Guide — New workflow or integration (docs/how-to-guides/)
  • Reference — New/changed API, config, or SDK method (docs/sdks/)
  • Concept — New mental model or architecture explanation (docs/core-concepts/)
  • App Flows — Changes to LearnCard App or ScoutPass user flows (docs/apps/)

Internal/AI Docs

  • CLAUDE.md — New pattern, flow, or context that AI assistants need
  • Code comments/JSDoc — Complex logic that needs inline explanation

Visual Documentation

  • Mermaid diagram — Complex flow, state machine, or architecture

💭 Documentation Notes

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have completed the Documentation Checklist above (or explained why N/A)

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

✨ PR Description

Purpose: Add empty state placeholder to AI Insights page to guide users without credentials and improve loading experience.

Main changes:

  • Created AiInsightsEmptyPlaceholder component with call-to-action to build LearnCard for unlocking insights
  • Extracted skeleton loader into separate AiInsightsLearningSnapshotsSkeletonLoader component for better code organization
  • Fixed AiInsightsSkillsCardSimple conditional rendering to only display when topSkills data exists
  • Moved closeAllModals call in logout flow to execute after redirect for proper cleanup

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: 06c296e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
learn-card-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 06c296e
🔍 Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/6945a742ade1560008923adf

@netlify
Copy link

netlify bot commented Dec 19, 2025

Deploy Preview for staging-learncardapp ready!

Name Link
🔨 Latest commit 06c296e
🔍 Latest deploy log https://app.netlify.com/projects/staging-learncardapp/deploys/6945a742152df70008f27a1e
😎 Deploy Preview https://deploy-preview-903--staging-learncardapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

👋 Hey there! It looks like you modified code, but didn't update the documentation in /docs.

If this PR introduces new features, changes APIs, or modifies behavior that users or developers need to know about, please consider updating the docs.


🏄 Windsurf Tip

You can ask Windsurf to help:

"Analyze the changes in this PR and update the gitbook docs in /docs accordingly."

Windsurf will review your changes and suggest appropriate documentation updates based on what was modified.


📚 Documentation Guide
Change Type Doc Location
New feature/API docs/tutorials/ or docs/how-to-guides/
SDK/API changes docs/sdks/
New concepts docs/core-concepts/
App UI/UX flows docs/apps/ (LearnCard App, ScoutPass)
Internal patterns CLAUDE.md

This is an automated reminder. If no docs are needed, feel free to ignore this message.

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The PR adds an empty placeholder for AI insights and refactors some components, but there's a concerning timing change in the logout logic that could affect user experience.

1 issues detected:

🐞 Bug - Modal closure timing changed from after-logout to before-logout, potentially creating UX inconsistencies on logout failure.

Details: The closeAllModals() call was moved from inside the setTimeout (after logout operations) to outside (before the 1-second delay). This means modals close immediately when logout starts, but if logout fails after the delay, modals will already be closed while the user remains logged in, creating a confusing user experience.
File: apps/learn-card-app/src/hooks/useLogout.tsx

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

@gitstream-cm
Copy link
Contributor

gitstream-cm bot commented Dec 19, 2025

🥷 Code experts: TaylorBeeston

TaylorBeeston has most 👩‍💻 activity in the files.
TaylorBeeston has most 🧠 knowledge in the files.

See details

apps/learn-card-app/src/hooks/useLogout.tsx

Activity based on git-commit:

TaylorBeeston
DEC 6 additions & 7 deletions
NOV 104 additions & 3 deletions
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
TaylorBeeston: 73%

apps/learn-card-app/src/pages/ai-insights/AiInsights.tsx

Activity based on git-commit:

TaylorBeeston
DEC 80 additions & 36 deletions
NOV 118 additions & 0 deletions
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
TaylorBeeston: 87%

apps/learn-card-app/src/pages/ai-insights/AiInsightsLearningSnapshots.tsx

Activity based on git-commit:

TaylorBeeston
DEC 6 additions & 3 deletions
NOV 127 additions & 0 deletions
OCT
SEP
AUG
JUL

Knowledge based on git-blame:
TaylorBeeston: 100%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

LGTM

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

Copy link
Collaborator

@goblincore goblincore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerardopar LGTM!

@gerardopar gerardopar merged commit eb3fe11 into main Dec 19, 2025
31 checks passed
@gerardopar gerardopar deleted the lc-1497 branch December 19, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants