-
Notifications
You must be signed in to change notification settings - Fork 8
[LC-1495] Did Web Cache Invalidation #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 9023a5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for staging-learncardapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for learncarddocs canceled.
|
|
👋 Hey there! It looks like you modified code, but didn't update the documentation in If this PR introduces new features, changes APIs, or modifies behavior that users or developers need to know about, please consider updating the docs. 🏄 Windsurf TipYou can ask Windsurf to help:
Windsurf will review your changes and suggest appropriate documentation updates based on what was modified. 📚 Documentation Guide
This is an automated reminder. If no docs are needed, feel free to ignore this message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
LGTM
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
|
🥷 Code experts: Custard7, gerardopar Custard7, gerardopar have most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Overview
🎟 Relevant Jira Issues
[LC-1495] DID:web cache not invalidating after claiming Boost (Manage Profile)
📚 What is the context and goal of this PR?
There's an annoying bug I've noticed for a while where the did web of a managed profile doesn't
invalidate in Redis after someone claims a boost that allows them to manage that profile. This effectively
means you have to wait until the cache clears before you can actually switch to that profile.
🥴 TL; RL:
This fixes the above issue by querying Neo4j directly to find the boost that a credential is an instance
of in this flow. Somehow there was an issue where it just wasn't correctly finding the right boost
and so not evicting the cache correctly. This is resolved now.
💡 Feature Breakdown (screenshots & videos encouraged!)
🛠 Important tradeoffs made:
An extra query when you claim a credential
🔍 Types of Changes
💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
Testing
🔬 How Can Someone QA This?
You can just run the tests =)
📱 🖥 Which devices would you like help testing on?
🧪 Code Coverage
Added unit test
Documentation
📝 Documentation Checklist
User-Facing Docs (
docs/→ docs.learncard.com)docs/tutorials/)docs/how-to-guides/)docs/sdks/)docs/core-concepts/)docs/apps/)Internal/AI Docs
Visual Documentation
- Mermaid diagram — Complex flow, state machine, or architecture
B[LearnCard] --> C[Network]