-
Notifications
You must be signed in to change notification settings - Fork 8
fix: [LC-1475] Gameflow styles #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for staging-learncardapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for learncarddocs canceled.
|
|
👋 Hey there! It looks like you modified code, but didn't update the documentation in If this PR introduces new features, changes APIs, or modifies behavior that users or developers need to know about, please consider updating the docs. 🏄 Windsurf TipYou can ask Windsurf to help:
Windsurf will review your changes and suggest appropriate documentation updates based on what was modified. 📚 Documentation Guide
This is an automated reminder. If no docs are needed, feel free to ignore this message. |
|
🥷 Code experts: TaylorBeeston TaylorBeeston has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
gerardopar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀🤠
Overview
🎟 Relevant Jira Issues
https://welibrary.atlassian.net/browse/LC-1475
📚 What is the context and goal of this PR?
Improve how gameflow looks and feels
🥴 TL; RL:
💡 Feature Breakdown (screenshots & videos encouraged!)
A side by side comparison video of the current live gameflow versus the fixed version (logged out state which is what the JIRA is primarily about):
gameflow2025-12-19.at.1.40.30.PM.mov
Fixes include:
🛠 Important tradeoffs made:
🔍 Types of Changes
💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
Testing
🔬 How Can Someone QA This?
In logged out state, go to gameflow link and see what it looks like and try to login via email:
Example link:
https://learncard.app/consent-flow?uri=lc:network:network.learncard.com/trpc:contract:50daff52-cc37-4ae4-bcd7-62ed71dd66f4
for local test:
http://localhost:3000/consent-flow?uri=lc:network:network.learncard.com/trpc:contract:50daff52-cc37-4ae4-bcd7-62ed71dd66f4
📱 🖥 Which devices would you like help testing on?
🧪 Code Coverage
Documentation
📝 Documentation Checklist
User-Facing Docs (
docs/→ docs.learncard.com)docs/tutorials/)docs/how-to-guides/)docs/sdks/)docs/core-concepts/)docs/apps/)Internal/AI Docs
Visual Documentation
- Mermaid diagram — Complex flow, state machine, or architecture
B[LearnCard] --> C[Network]