Skip to content

Conversation

@smurflo2
Copy link
Collaborator

Overview

🎟 Relevant Jira Issues

📚 What is the context and goal of this PR?

Follow up to this PR so that react-learn-card gets a proper changeset/version bump

🥴 TL; RL:

💡 Feature Breakdown (screenshots & videos encouraged!)

🛠 Important tradeoffs made:

🔍 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (refactor, documentation update, etc)

💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )

  • No
  • Yes

Testing

🔬 How Can Someone QA This?

📱 🖥 Which devices would you like help testing on?

🧪 Code Coverage

Documentation

📜 Gitbook

📊 Storybook

✅ PR Checklist

  • Related to a Jira issue (create one if not)
  • My code follows style guidelines (eslint / prettier)
  • I have manually tested common end-2-end cases
  • I have reviewed my code
  • I have commented my code, particularly where ambiguous
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to gitbook documentation

🚀 Ready to squash-and-merge?:

  • Code is backwards compatible
  • There is not a "Do Not Merge" label on this PR
  • I have thoughtfully considered the security implications of this change.
  • This change does not expose new public facing endpoints that do not have authentication

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 188b33c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@learncard/react Patch
learn-card-app Patch
scoutpass-app Patch
@learncard/chapi-example Patch
@learncard/snap-chapi-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for learncarddocs canceled.

Name Link
🔨 Latest commit 188b33c
🔍 Latest deploy log https://app.netlify.com/projects/learncarddocs/deploys/694052e4093a3700080768dd

@smurflo2 smurflo2 merged commit 4b833c0 into main Dec 15, 2025
9 checks passed
@smurflo2 smurflo2 deleted the lc-1489 branch December 15, 2025 18:26
@netlify
Copy link

netlify bot commented Dec 15, 2025

Deploy Preview for staging-learncardapp canceled.

Name Link
🔨 Latest commit 188b33c
🔍 Latest deploy log https://app.netlify.com/projects/staging-learncardapp/deploys/694052e445a9430008d67456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants