-
Notifications
You must be signed in to change notification settings - Fork 8
[LC-634] Default Permissions When Claiming #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d3d198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for learn-card-chapi-example canceled.
|
✅ Deploy Preview for learncarddocs canceled.
|
goblincore
approved these changes
Nov 25, 2024
Collaborator
goblincore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
🎟 Relevant Jira Issues
[LC-634] Back-End: Default Role when Claiming
📚 What is the context and goal of this PR?
To ease with the troops setup, we want to be able to set a default role/permissions that you get automatically
when claiming a boost
🥴 TL; RL:
Adds the ability to give a profile default permissions at the time that they claim a boost
💡 Feature Breakdown (screenshots & videos encouraged!)
claimPermissionsfield on them.claimPermissionsis just a regular permissions object that specifies the permissions a user gets when claiming the boostclaimPermissions, a newRolenode is made and attached with those permissions!🛠 Important tradeoffs made:
🔍 Types of Changes
💳 Does This Create Any New Technical Debt? ( If yes, please describe and add JIRA TODOs )
Testing
🔬 How Can Someone QA This?
Just run the test suite =)
If you'd like to try it out yourself, spin up the LCN with docker (
cd services/learn-card-network && docker compose up)Then:
📱 🖥 Which devices would you like help testing on?
🧪 Code Coverage
I wrote tests for claiming via
acceptCredentialas well as via a claim linkDocumentation
📜 Gitbook
📊 Storybook
✅ PR Checklist
🚀 Ready to squash-and-merge?: