API refactoring #438
Open
API refactoring #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_programming_course into an/unite-tests # Conflicts: # .github/workflows/codeql.yml # .github/workflows/main.yml # .github/workflows/static-analysis-pr.yml # modules/core/task/src/task.cpp
Refactored test parameter structs and macros to enhance readability and flexibility, including the addition of `FuncTestParam` and `PerfTestParam` types. Updated test case naming conventions with custom functions for better identification. Simplified utility functions and macros for improved code maintainability.
Updated functional tests and scripts to support dynamically filtering tasks by type. Refactored execution logic to reduce redundancy and improve maintainability. Adjusted macros and utility functions for better namespace resolution.
Standardized line formatting in test definitions and Python scripts. Adjustments enhance code readability without altering functionality or behavior.
Simplify `ExecuteTest` by encapsulating parameters into a single struct. This reduces redundancy and improves code readability across test execution functions. Updated affected test cases to align with the new parameter structure.
Replaced direct handling of task pointers with BaseRunFuncTests for cleaner and reusable test logic. Renamed kAddParams to kTestParams for better semantic clarity. Improved test output validation by overriding CheckTestOutputData in derived test classes.
Extracted data preparation logic into a dedicated function for better readability and modularization. Introduced a new input member in the base test class to streamline test input management. Adjusted lambda and tuple type naming for consistency and clarity.
Refactored the `BaseRunFuncTests` class to simplify and improve test execution and data handling. Replaced `GetTestInput` and `GetTaskPtr` with `GetTestInputData` and `CheckTestOutputData` for cleaner abstraction. Updated error handling and validation logic for better test reliability and maintainability.
Replaced hardcoded task tuples with dynamic generation using templates for better scalability and reusability. Added utility functions to simplify tuple expansion for test parameterization, improving code maintainability.
Replaced inline TestParamInfo definitions with the GTestFuncParam alias to improve readability and maintainability. This ensures consistent usage of type aliases across the codebase and reduces redundancy in test parameter handling.
Renamed `DEFINE_GEN_TASK_TUPLES` to `DEFINE_GEN_TASK` and updated associated functions to streamline task generation. Simplified code structure by adjusting macro usage and wrapping test cases in an anonymous namespace for better encapsulation.
Updated task class names across all modules to follow the NesterovATestTask* naming convention. Renamed the `FuncTestParamIndex` enum to `TestParamIndex` for consistency. Adjusted related function definitions and testing suits accordingly.
Simplified the `FuncTestParam` type usage by removing redundant namespace prefixes and updated the test name generation logic for better reuse. Introduced a static interface requirement and concept check to ensure derived classes implement `PrintTestParam`. These changes improve code readability and enforce clearer contracts for test classes.
…nd improve readability.
…pendencies in GitHub workflow file
github-actions
bot
added
task:mpi
task:omp
task:tbb
task:seq
task:stl
ci
infrastructure
3rdparty
core
task:all
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 95.78% 89.80% -5.99%
==========================================
Files 16 11 -5
Lines 261 353 +92
Branches 87 121 +34
==========================================
+ Hits 250 317 +67
- Misses 4 19 +15
- Partials 7 17 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…le modules and tasks Standardized header imports, removed unused includes, and introduced a shared JSON pointer initialization method (`InitJSONPtr`) for improved code reusability. Adjusted related logic in task handling for consistency and robustness.
# Conflicts: # codecov.yml
…ency, and clean up MPI-related imports across modules and tasks
…and streamline MPI-related imports and logic
…cov ignore patterns for consistency
…GitHub Action steps for unused performance counting functionality.
…ing unused MPI-related dependencies.
…low for improved compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.