Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification on stale dependency diagnostic #393

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

mhuisi
Copy link
Collaborator

@mhuisi mhuisi commented Feb 7, 2024

Client side for leanprover/lean4#3247.

github-merge-queue bot pushed a commit to leanprover/lean4 that referenced this pull request Mar 18, 2024
Sends a diagnostic informing the user to run Restart File when a file
dependency is saved.

Based on #3014 because this feature was easier to implement with the new
architecture.

ToDo:
- [x] Adjust vscode-lean4 to display a notification when this diagnostic
appears in a non-annoying way
(leanprover/vscode-lean4#393)
- [x] Use a file watcher to identify changes to files not tracked by VS
Code
- [x] Rebase onto master when #3014 is merged
@mhuisi mhuisi merged commit e321fde into leanprover:master Mar 18, 2024
@mhuisi mhuisi deleted the mhuisi/stale-dep-notif branch March 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant