feat: template creation in the admin menu - #118
Conversation
d4732a5 to
152ee64
Compare
152ee64 to
90acb8a
Compare
c60ea13 to
4562ad7
Compare
87ed48c to
d86830d
Compare
40d0869 to
33c65f0
Compare
1ce763b to
3007452
Compare
d5d1b3c to
d6a3d84
Compare
ea4368d to
efe9086
Compare
jcreedcmu
left a comment
There was a problem hiding this comment.
Is it the case that seed-volume.sh makes package-sets/mathlib-$LEAN_VERSION e.g. mathlib-v4.32.0 and yet create-tagged-lib.sh makes package-sets/mathlib-${LEAN_VERSION//./-} e.g. mathlib-v4-32-0? Seems like it would be better to be consistent. (I think the template name always has dashes in either path)
|
Also: totally optional but I think I would add like |
It would be better to be consistent - but it might be better to be consistent between |
ah, if #121 obviates this, then my concern is moot. Thanks for explaining. |
jcreedcmu
left a comment
There was a problem hiding this comment.
Approved now given changes you are planning.
ceab693 to
0428289
Compare
This PR makes it possible to create templates in the admin menu. Addresses (but does not close) #21. After selecting an installed toolchain, the interface will let you select:
The Mathlib and CSLib options will only be presented for standard release toolchains (no nightly-testing) where we've checked that the tag corresponds to a valid Mathlib/CSLib (respectively) tag. This is done with the GitHub API, and uses the higher 5000-requests-an-hour rate limit by authorizing with the configured GitHub OAuth App.