feat: toolchain management - #114
Merged
Merged
Conversation
robsimmons
force-pushed
the
manage-toolchain
branch
2 times, most recently
from
September 3, 2026 01:46
b38f44e to
3da0762
Compare
robsimmons
force-pushed
the
manage-toolchain
branch
2 times, most recently
from
September 3, 2026 16:01
dae78ad to
61e3968
Compare
robsimmons
force-pushed
the
manage-toolchain
branch
3 times, most recently
from
September 5, 2026 16:29
2cc53b9 to
c63dfc7
Compare
robsimmons
force-pushed
the
manage-toolchain
branch
2 times, most recently
from
September 6, 2026 12:35
21d4e6c to
760d77b
Compare
Toolchains can be introduced with a second use of TrackedCommandForm, and modified with the same kind of inline modification form initially used for active editor sessions and duplciated for project templates
robsimmons
force-pushed
the
manage-toolchain
branch
from
September 6, 2026 12:42
760d77b to
ad1b052
Compare
jcreedcmu
reviewed
Sep 8, 2026
| const { stderr, stdout } = await exec(getElanBin(), ['toolchain', 'list'], { | ||
| env: { ...process.env, ELAN_HOME }, | ||
| }) | ||
| // a successful `elan toolchain list` prints nothing on standard output |
Collaborator
There was a problem hiding this comment.
do you mean 'standard error' here in the comment?
jcreedcmu
reviewed
Sep 8, 2026
| env: { ...process.env, ELAN_HOME }, | ||
| }) | ||
| // a successful `elan toolchain uninstall ...` produces nothing on standard error | ||
| if (stdout.trim().length !== 0) throw new Error(stdout) |
Collaborator
There was a problem hiding this comment.
I'm also confused here... either the "standard error" or the "stdout" needs to be changed, or my understanding is wrong.
jcreedcmu
requested changes
Sep 8, 2026
Collaborator
Author
|
@jcreedcmu I indeed wrote a clarifying comment to communicate weird asymmetric behavior with |
Collaborator
Author
|
@jcreedcmu if the requested changes were just the misleading comments those are now fixed |
jcreedcmu
reviewed
Sep 9, 2026
| * | ||
| * Results for normally-installed release or nightly toolchains are in long-form, e.g. | ||
| * `leanprover/lean4-nightly:nightly-2026-08-27` or `leanprover/lean4:v4.32.2`. | ||
| */ |
Collaborator
There was a problem hiding this comment.
Optional: toss a link here to https://lean-lang.org/doc/reference/latest/Build-Tools-and-Distribution/Managing-Toolchains-with-Elan/
jcreedcmu
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25. Toolchains can be introduced with a second use of TrackedCommandForm, and modified with the same kind of inline modification form initially used for active editor sessions and duplicated for project templates
Selecting toolchain:
Downloading toolchain:
Removing toolchain (two-click confirmation)
