feat: additional tests for bad recursors - #159
Closed
ammkrn wants to merge 1 commit into
Closed
Conversation
Two additional tests to ensure the kernel rejects a recursor which improperly (1) declares it is derived from a nonexistent inductive type, or (2) declares no inductive type from which it is derived. These are more likely to be issues in kernels that rely on the recursors appearing in the export file, and then re-check the types based on post hoc derivations.
Contributor
Author
|
When I opened this I saw that @nomeata beat me by a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two additional tests to ensure the kernel rejects a recursor which improperly (1) declares it is derived from a nonexistent inductive type, or (2) declares no inductive type from which it is derived. These are more likely to be issues in kernels that rely on the recursors appearing in the export file, and then re-check the types based on post hoc derivations.