fix: mathlib4 breakage from nightly-2026-09-11 - #69
Merged
Conversation
The bump from `nightly-2026-09-10` to `nightly-2026-09-11` (the bump commit changes only `lean-toolchain`) pushes the `Algebra K (IsScalarTower.toAlgHom K F L).fieldRange` instance search in `IsGaloisGroup.of_isScalarTower` just past the default `synthInstance.maxHeartbeats` of 20000; with Mathlib's `leanOptions` 21000 already suffices. The same failure appeared on the lean4#15090 and lean4#15066 pr-releases once they were based on lean4 master after nightly-2026-09-10, and both adaptation branches raise the limit. Mirror the hunk of adaptation-15090 (#64) verbatim, so that the file ends up byte-identical to that branch and its eventual merge stays clean.
Kha
enabled auto-merge (squash)
September 11, 2026 11:51
Contributor
Build report for fix: mathlib4 breakage from nightly-2026-09-11Turned green:
Stayed green
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
masterafter the bump tonightly-2026-09-11(run 34590361152). One commit,mathlib4only.mathlib4
Cause. The bump commit changes only
lean-toolchain, yetMathlib.FieldTheory.Galois.IsGaloisGroupstops compiling:It is a small drift. With Mathlib's
leanOptions(maxSynthPendingDepth := 3),synthInstance.maxHeartbeats 21000is already enough onnightly-2026-09-11. The adaptation branches for lean4#15090 (#64) and lean4#15066 (#59) hit the same error once their pr-releases were based on lean4 master pastnightly-2026-09-10;pr-release-15090-0d7390f(based on thenightly-2026-09-10commit) was fine andpr-release-15090-61a42c0(based on lean4#15098) was not. That puts the cause among lean4#15001, #15093, #15060, #15048, #15107 and #15098. None of these obviously changes allocation counts inside instance synthesis, so I have not pinned it to one PR.Fix.
set_option synthInstance.maxHeartbeats 80000 inonIsGaloisGroup.of_isScalarTower, with the justifying comment the style linter asks for. This copies #64's hunk verbatim (the resulting blob is identical to the one onadaptation-15090), so merging #64 later stays clean. #59 raises the same limit to 40000 and will conflict on this line either way.Verified locally on
nightly-2026-09-11:lake build Mathlib Archive Counterexamples Wanted --wfail,lake test --iofailandlake lintall pass.cslib
CI skipped it behind mathlib4, so it has not been built on this nightly. Verified locally, no change needed:
lake build --wfail --iofail,lake test --wfail --iofailandlake lintall pass.repl
Its
lake testfailed only as a knock-on:test.shbuilds real Mathlib intest/Mathlib, which stopped at the sameIsGaloisGrouperror, andH20231110then failed becauseRealwas unavailable. No change needed. Verified locally:lake buildandlake testpass with this fix.Unfinished
Nothing.