Remove @[simp] from theorems flagged by simpVarHead linter - #130
Merged
Conversation
grunweg
force-pushed
the
fix-simpVarHead-linter
branch
from
November 24, 2025 08:50
6b5b607 to
42d76ad
Compare
The simpVarHead linter flags simp lemmas where the left-hand side has a variable as the head symbol. This removes the @[simp] attribute from three such theorems: - OpenSmoothEmbedding.coe_mk (SphereEversion/Global/SmoothEmbedding.lean:47) - Loop.coe_mk (SphereEversion/Loops/Basic.lean:46) - EquivariantMap.coe_mk (SphereEversion/ToMathlib/Equivariant.lean:43) These lemmas have variables as head symbols in their left-hand sides, which makes them unsuitable as simp lemmas. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
grunweg
force-pushed
the
fix-simpVarHead-linter
branch
from
November 24, 2025 09:11
90d9f66 to
1f3d461
Compare
Collaborator
|
Thanks for the fixes! I verified locally that all three attributes caused linter errors before and are now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
@[simp]attribute from three lemmas that were flagged by thesimpVarHeadlinter:OpenSmoothEmbedding.coe_mk(inGlobal.SmoothEmbedding)Loop.coe_mk(inLoops.Basic)EquivariantMap.coe_mk(inToMathlib/Equivariant)The
simpVarHeadlinter flags simp lemmas where the left-hand side has a variable as the head symbol. These lemmas are problematic as simp lemmas because the head symbol is a variable (the function being coerced), which makes them unsuitable for automated simplification.🤖 Generated with Claude Code