chore: fix unusedArguments linter warnings - #128
Closed
kim-em wants to merge 1 commit into
Closed
Conversation
kim-em
force-pushed
the
fix-unused-arguments
branch
from
November 24, 2025 01:53
db5b65a to
cc68a98
Compare
This PR fixes all `unusedArguments` linter warnings by: - Removing unused type class instances from function signatures - Adding `omit` directives for unused section variables Files changed: - `Loops/Basic.lean`: Remove unused `FirstCountableTopology` and `LocallyCompactSpace` from `continuous_average` - `ToMathlib/Analysis/Calculus.lean`: Remove unused `IsOrderedMonoid`/`IsOrderedAddMonoid` from `WithTop` lemmas - `ToMathlib/Analysis/Convex/Basic.lean`: Remove unused `IsOrderedRing` from definitions and add `omit` directives - `Local/Corrugation.lean`: Remove unused `FirstCountableTopology` and `LocallyCompactSpace` from `c0_small_on` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
grunweg
force-pushed
the
fix-unused-arguments
branch
from
November 24, 2025 09:14
757fd21 to
a8da7c6
Compare
grunweg
added a commit
that referenced
this pull request
Nov 24, 2025
Cherry-picked from #128 by `kim-em`, thank you!
Collaborator
|
Thanks for your PR! I redid the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all
unusedArgumentslinter warnings by:omitdirectives for unused section variablesChanges
Files modified:
Loops/Basic.lean: Remove unusedFirstCountableTopologyandLocallyCompactSpacefromcontinuous_averageToMathlib/Analysis/Calculus.lean: Remove unusedIsOrderedMonoid/IsOrderedAddMonoidfromWithToplemmasToMathlib/Analysis/Convex/Basic.lean: Remove unusedIsOrderedRingfrom definitions and addomitdirectives for theoremsLocal/Corrugation.lean: Remove unusedFirstCountableTopologyandLocallyCompactSpacefromc0_small_onTesting
All changes have been verified with
lake build. TheunusedArgumentslinter now reports no errors.🤖 Generated with Claude Code