Skip to content

feat: Add reviewer checklist - #1361

Merged
jstoobysmith merged 4 commits into
leanprover-community:masterfrom
jstoobysmith:reviewCheckList
Jul 14, 2026
Merged

feat: Add reviewer checklist#1361
jstoobysmith merged 4 commits into
leanprover-community:masterfrom
jstoobysmith:reviewCheckList

Conversation

@jstoobysmith

Copy link
Copy Markdown
Member

Adding a reviewer checklist based on questions a reviewer might want to ask themselves.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally.

If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks.

If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip.

Important: If a reviewer adds an awaiting-author label to your PR, once you have addressed the review comments, please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

Comment thread docs/ReviewChecklist.md
jstoobysmith and others added 3 commits July 3, 2026 13:00
Co-authored-by: nateabr <135662056+nateabr@users.noreply.github.com>
Co-Authored-By: nateabr <135662056+nateabr@users.noreply.github.com>
@nateabr nateabr added reviewer-approved easy < 20s of review time labels Jul 10, 2026
@morrison-daniel morrison-daniel added the ready-to-merge This PR is approved and will be merged shortly label Jul 13, 2026
@jstoobysmith
jstoobysmith merged commit 346f438 into leanprover-community:master Jul 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time ready-to-merge This PR is approved and will be merged shortly reviewer-approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants