refactor(QuantumMechanics): SpaceDHilbertSpace API - #1338
Conversation
|
t-quantum-mechanics |
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
jstoobysmith
left a comment
There was a problem hiding this comment.
These changes look good to me. Approved - will merge shortly
Make a few improvements to the
SpaceDHilbertSpaceAPI:toBrato an (antilinear) equivalence.MemHSnamespace.coeFn_[...]lemmas to use in place of theirAEEqFuncounterparts (c.f. line 242 inPolyBddSchwartzSubmodule.lean).