Skip to content

fix(lint-style.py): make the code compile again - #43993

Open
grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:fix-lint-style
Open

grunweg wants to merge 1 commit into
leanprover-community:masterfrom
grunweg:fix-lint-style

Conversation

@grunweg

@grunweg grunweg commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Most of these checks will be obsolete by the new auto-formatter: arguably, this entire script could be removed in the mean-time, if this places a too large maintainance burden.


Open in Gitpod

Most of these checks will be obsolete by the new auto-formatter:
arguably, this entire script could be removed in the mean-time, if
this places a too large maintainance burden.
@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

PR summary 118d534f47

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 118d534).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit 118d534f47
Reference commit b1007d8abf

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions

Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

labels are []
error: a PR's scope should be a directory or file name, not a module name
hint: the scope contains a dot, use forward slashes instead
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@grunweg

grunweg commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

This PR only fixes part of the issue: a better course of action might be to remove the script entirely: #43994 does so.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-linter Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant