Skip to content

feat(Algebra/GroupWithZero/Range): add lemmas - #43675

Open
mariainesdff wants to merge 4 commits into
leanprover-community:masterfrom
mariainesdff:gpwz_range
Open

mariainesdff wants to merge 4 commits into
leanprover-community:masterfrom
mariainesdff:gpwz_range

Conversation

@mariainesdff

@mariainesdff mariainesdff commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Co-authored-by: @xgenereux


Open in Gitpod

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

PR summary 5a2f847ff4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ exists_mk
+ mem_valueGroup_iff_exists_mk_of_comm
+ mk_eq_div
+ restrict₀_inj

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 5a2f847).

  • +4 new declarations
  • −0 removed declarations
+MonoidWithZeroHom.ValueGroup₀.restrict₀_inj
+MonoidWithZeroHom.mem_valueGroup_iff_exists_mk_of_comm
+MonoidWithZeroHom.valueGroup.exists_mk
+MonoidWithZeroHom.valueGroup.mk_eq_div

No changes to strong technical debt.
No changes to weak technical debt.

Current commit 5a2f847ff4
Reference commit 7e195f2805

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 10, 2026

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Comment thread Mathlib/Algebra/GroupWithZero/Range.lean Outdated
@github-actions

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Sep 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants