Skip to content

[Merged by Bors] - refactor(RingTheory/RamificationInertia/Ramification): generalize ramificationIdx_pos - #41377

Closed
tb65536 wants to merge 14 commits into
leanprover-community:masterfrom
tb65536:tb_dpriue830
Closed

tb65536 wants to merge 14 commits into
leanprover-community:masterfrom
tb65536:tb_dpriue830

Conversation

@tb65536

@tb65536 tb65536 commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Positivity of ramification index currently requires Module.Finite, but it is also true for Dedekind domains. This PR extracts a common generalization ramificationIdx_pos_of_mem_minimalPrimes and deduces these two facts as corollaries. This allows for a few more removals of the old ramificationIdx'.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

PR summary a10433c0de

Import changes exceeding 2%

% File
+3.87% Mathlib.NumberTheory.RamificationInertia.Valuation

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.NumberTheory.RamificationInertia.Valuation 2715 2820 +105 (+3.87%)
Import changes for all files
Files Import difference
Mathlib.NumberTheory.RamificationInertia.Valuation 105

Declarations diff (regex)

+ Ideal.mem_minimalPrimes_of_ne_bot
+ ramificationIdx_pos_of_isDedekindDomain
+ ramificationIdx_pos_of_isDedekindDomain'
+ ramificationIdx_pos_of_mem_minimalPrimes

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit a10433c).

  • +4 new declarations
  • −0 removed declarations
+Ideal.mem_minimalPrimes_of_ne_bot
+Ideal.ramificationIdx_pos_of_isDedekindDomain
+Ideal.ramificationIdx_pos_of_isDedekindDomain'
+Ideal.ramificationIdx_pos_of_mem_minimalPrimes

No changes to strong technical debt.
No changes to weak technical debt.

Current commit a10433c0de
Reference commit 9d63ad78de

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 5, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 5, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
…on proof (#41378)

This PR extracts an instance from the proof of `Ideal.ramificationIdx_pos`. This is a prerequisite for #41377.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
mathlib-bors Bot pushed a commit that referenced this pull request Sep 3, 2026
…on proof (#41378)

This PR extracts an instance from the proof of `Ideal.ramificationIdx_pos`. This is a prerequisite for #41377.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 3, 2026
@github-actions github-actions Bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Sep 3, 2026
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Sep 5, 2026
…on proof (leanprover-community#41378)

This PR extracts an instance from the proof of `Ideal.ramificationIdx_pos`. This is a prerequisite for leanprover-community#41377.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 16, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 16, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 22, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 22, 2026

@riccardobrasca riccardobrasca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Comment thread Mathlib/RingTheory/RamificationInertia/Ramification.lean Outdated
@mathlib-bors mathlib-bors Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 23, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

✌️ tb65536 can now approve this pull request until 2026-10-07 07:39 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, Wanted/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean, Wanted.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@tb65536

tb65536 commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

bors r+

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Sep 23, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Sep 23, 2026
…mificationIdx_pos` (#41377)

Positivity of ramification index currently requires `Module.Finite`, but it is also true for Dedekind domains. This PR extracts a common generalization `ramificationIdx_pos_of_mem_minimalPrimes` and deduces these two facts as corollaries. This allows for a few more removals of the old `ramificationIdx'`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Sep 23, 2026
@mathlib-bors

mathlib-bors Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@mathlib-bors mathlib-bors Bot changed the title refactor(RingTheory/RamificationInertia/Ramification): generalize ramificationIdx_pos [Merged by Bors] - refactor(RingTheory/RamificationInertia/Ramification): generalize ramificationIdx_pos Sep 23, 2026
@mathlib-bors mathlib-bors Bot closed this Sep 23, 2026
@mathlib-bors mathlib-bors Bot removed the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bors-staging This PR is currently being built by bors on the staging branch. large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants