Conversation
PR summary a10433c0deImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.NumberTheory.RamificationInertia.Valuation | 2715 | 2820 | +105 (+3.87%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.NumberTheory.RamificationInertia.Valuation |
105 |
Declarations diff (regex)
+ Ideal.mem_minimalPrimes_of_ne_bot
+ ramificationIdx_pos_of_isDedekindDomain
+ ramificationIdx_pos_of_isDedekindDomain'
+ ramificationIdx_pos_of_mem_minimalPrimes
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
a10433c).
- +4 new declarations
- −0 removed declarations
+Ideal.mem_minimalPrimes_of_ne_bot
+Ideal.ramificationIdx_pos_of_isDedekindDomain
+Ideal.ramificationIdx_pos_of_isDedekindDomain'
+Ideal.ramificationIdx_pos_of_mem_minimalPrimesNo changes to strong technical debt.
No changes to weak technical debt.
Current commit a10433c0de
Reference commit 9d63ad78de
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
…on proof (leanprover-community#41378) This PR extracts an instance from the proof of `Ideal.ramificationIdx_pos`. This is a prerequisite for leanprover-community#41377. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
|
This pull request has conflicts, please merge |
|
This pull request has conflicts, please merge |
|
✌️ tb65536 can now approve this pull request until 2026-10-07 07:39 UTC (in 2 weeks). To approve and merge, reply with
|
|
bors r+ |
…mificationIdx_pos` (#41377) Positivity of ramification index currently requires `Module.Finite`, but it is also true for Dedekind domains. This PR extracts a common generalization `ramificationIdx_pos_of_mem_minimalPrimes` and deduces these two facts as corollaries. This allows for a few more removals of the old `ramificationIdx'`. Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
ramificationIdx_posramificationIdx_pos
Positivity of ramification index currently requires
Module.Finite, but it is also true for Dedekind domains. This PR extracts a common generalizationramificationIdx_pos_of_mem_minimalPrimesand deduces these two facts as corollaries. This allows for a few more removals of the oldramificationIdx'.