Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary c323074686Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
|
This pull request has conflicts, please merge |
…lib4 into x3/algebraic-tower-law
|
I noticed some improvements are possible to #41614 when merging but it'll be a nontrivial amount of code so I'll make it a different PR |
I think it would be better if you merge master and just do it now. |
|
OK. Let me know if you want me to split it up after all, the diff ended up a bit bigger than I was expecting. |
|
-awaiting-author |
| theorem finrank_mul_finrank : | ||
| finrank R S * finrank S M = finrank R M := |
There was a problem hiding this comment.
No need for some of these newlines.
| theorem finrank_mul_finrank : | |
| finrank R S * finrank S M = finrank R M := | |
| theorem finrank_mul_finrank : finrank R S * finrank S M = finrank R M := |
There was a problem hiding this comment.
I edited the two near that but left others unchanged despite being able to fit on one line within col limit (since I find that for long theorem names it makes it hard to tell what the type is at a glance)
|
-awaiting-author |
We generalise the tower law for
Module.rankto the situation of a module over an algebraic extension of domains.See the Zulip thread for some associated discussion.
I am not sure about in which file these results should live, or what their names should be. For the file I have gone with
LinearAlgebra/Dimension/Algebraic.leanfor now, because these feel more like dimension theorems thanAlgebra.IsAlgebraictheorems, and IMO do not logically fit into the other existing files inLinearAlgebra/Dimension.