Skip to content

feat(LinearAlgebra/Projection): add results about inverse of Submodule.prodEquivOfIsCompl #26462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PSchwahn
Copy link
Contributor

@PSchwahn PSchwahn commented Jun 27, 2025

Add two theorems Submodule.prodEquivOfIsCompl_symm_apply and Submodule.prodEquivOfIsCompl_symm_add, which are API for Submodule.prodEquivOfIsCompl.

We believe these theorems are useful; for example, we have used their statements in a classification formalization project.

I am not sure whether the prodEquivOfIsCompl_symm_apply theorem should be tagged with @[simp]; this might lead to confluence issues. Opinions are welcome!

Co-authored by:


Open in Gitpod

@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc) labels Jun 27, 2025
Copy link

github-actions bot commented Jun 27, 2025

PR summary 2e9119ae9e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ prodEquivOfIsCompl_symm_add
+ prodEquivOfIsCompl_symm_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@PSchwahn PSchwahn marked this pull request as ready for review June 27, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants