-
Notifications
You must be signed in to change notification settings - Fork 761
perf: lower the priority of Comm*.to*
instances
#18472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
PR summary 51ade5646b
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.NumberTheory.LegendreSymbol.GaussEisensteinLemmas | 1543 | 1336 | -207 (-13.42%) |
Mathlib.NumberTheory.Zsqrtd.QuadraticReciprocity | 1552 | 1352 | -200 (-12.89%) |
Mathlib.NumberTheory.NumberField.Discriminant.Defs | 1646 | 1441 | -205 (-12.45%) |
Mathlib.NumberTheory.Padics.PadicNumbers | 1290 | 1142 | -148 (-11.47%) |
Mathlib.Topology.MetricSpace.Polish | 1268 | 1259 | -9 (-0.71%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.NumberTheory.LegendreSymbol.GaussEisensteinLemmas |
-207 |
Mathlib.NumberTheory.NumberField.Discriminant.Defs |
-205 |
Mathlib.NumberTheory.Zsqrtd.QuadraticReciprocity Mathlib.NumberTheory.SumTwoSquares |
-200 |
Mathlib.NumberTheory.Padics.PadicNumbers Mathlib.NumberTheory.Harmonic.Int |
-148 |
Mathlib.NumberTheory.Padics.PadicIntegers |
-109 |
Mathlib.Algebra.Homology.Embedding.Basic |
-101 |
Mathlib.NumberTheory.Padics.RingHoms |
-89 |
Mathlib.RingTheory.WittVector.Compare |
-84 |
Mathlib.Algebra.Module.LinearMap.Rat Mathlib.Algebra.Module.Rat |
-37 |
12 filesMathlib.Algebra.Star.Module Mathlib.CategoryTheory.Monoidal.Linear Mathlib.Algebra.Category.ModuleCat.Monoidal.Symmetric Mathlib.Algebra.Category.ModuleCat.Monoidal.Basic Mathlib.Algebra.Algebra.Unitization Mathlib.CategoryTheory.Quotient.Linear Mathlib.Algebra.Homology.ShortComplex.Linear Mathlib.RepresentationTheory.Action.Limits Mathlib.Algebra.Category.ModuleCat.Monoidal.Closed Mathlib.CategoryTheory.Monoidal.Subcategory Mathlib.Algebra.Homology.Linear Mathlib.CategoryTheory.Linear.LinearFunctor |
-33 |
4 filesMathlib.Algebra.Homology.Embedding.HomEquiv Mathlib.Algebra.Homology.Embedding.Extend Mathlib.Algebra.Homology.Embedding.Boundary Mathlib.Algebra.Homology.Embedding.Restriction |
-29 |
21 filesMathlib.Data.Matrix.Auto Mathlib.Data.Matrix.Invertible Mathlib.Data.Matrix.Composition Mathlib.Data.Matrix.Basic Mathlib.Data.Matrix.Basis Mathlib.GroupTheory.Coxeter.Matrix Mathlib.Data.Matrix.PEquiv Mathlib.Data.Matrix.CharP Mathlib.Data.Matrix.Block Mathlib.CategoryTheory.Preadditive.Mat Mathlib.Data.Matrix.Reflection Mathlib.LinearAlgebra.Matrix.Trace Mathlib.LinearAlgebra.Matrix.Symmetric Mathlib.Data.Matrix.RowCol Mathlib.Data.Matrix.DualNumber Mathlib.Data.Matrix.Hadamard Mathlib.Combinatorics.Optimization.ValuedCSP Mathlib.Combinatorics.SimpleGraph.IncMatrix Mathlib.Data.Matrix.Notation Mathlib.LinearAlgebra.Matrix.Circulant Mathlib.LinearAlgebra.Matrix.Orthogonal |
-25 |
10 filesMathlib.LinearAlgebra.FinsuppVectorSpace Mathlib.Algebra.Category.ModuleCat.Adjunctions Mathlib.LinearAlgebra.Matrix.Ideal Mathlib.LinearAlgebra.Matrix.DotProduct Mathlib.Algebra.Module.Projective Mathlib.RepresentationTheory.Action.Monoidal Mathlib.LinearAlgebra.TensorProduct.Basis Mathlib.RingTheory.Localization.FractionRing Mathlib.LinearAlgebra.FreeModule.Basic Mathlib.LinearAlgebra.StdBasis |
-10 |
Mathlib.Topology.MetricSpace.Polish Mathlib.Topology.MetricSpace.Perfect |
-9 |
Mathlib.GroupTheory.Coxeter.Basic |
-8 |
3 filesMathlib.Data.Rat.Denumerable Mathlib.MeasureTheory.Constructions.Polish.EmbeddingReal Mathlib.MeasureTheory.Constructions.Polish.Basic |
-5 |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
This PR/issue depends on: |
1 task
!bench |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-bench
blocked-by-other-PR
This PR depends on another PR (this label is automatically managed by a bot)
slow-typeclass-synthesis
t-algebra
Algebra (groups, rings, fields, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommRing.toRing
is an exception.CommRing
is so important that it needs to be looked up early. An important goal of #7873 is also to search forZero/One/Add/Mul
instances first alongZero/One/Add/Mul
-> ... ->Ring
->CommRing
->Field
.*WithOne.to*
instances #18474*.toRing
instances #18641From #7873.