You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looks great. I was a little hesitant that there would be situations where the symbols were ambiguous, but I suppose this shows that's not the case--do you agree?
Looks great. I was a little hesitant that there would be situations where the symbols were ambiguous, but I suppose this shows that's not the case--do you agree?
We are reusing the symbols ✓ for CMRA.Included and ≼ for CMRA.Valid, but there is no ambiguity as CMRA.Included a b and CMRA.Valid a are of type Prop while internalCmraIncluded a b and internalCmraValid a are of type PROP, so it's not possible that we accidentally use the wrong symbol as it would not be type-correct.
Same for the distinction between internalEq and equivalence.
Sounds great. The only overlap would be a BI instance for Prop itself, but perhaps we should cross that bridge when we come to it. If so, a fix would be to put the CMRA and BI notations in different scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port the notations for
internalCmraValid,internalEq,internalIncluded.Addresses #300 and #234.
Checklist
authorssection of any appropriate files