feat: make SSZVector of Fp serializable - #223
Merged
Merged
Conversation
tcoratger
reviewed
Dec 5, 2025
tcoratger
left a comment
Collaborator
There was a problem hiding this comment.
Can we have some small unit tests for this?
Even if this is pretty obvious, that is probably better to have tests in order to confirm that nothing is broken in the future with this.
Collaborator
Author
|
@tcoratger Sorry I forgot to add. Would this be enough? 728f736 |
This was referenced Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
I was having issue with getting #193 to output the signatures to test vectors. It looks like SSZVector didn't know how to serialize Fp. 3 main changes are done:
Reverted. Turns out it's not needed anymoreFp.__get_pydantic_core_schema__()is implemented similar toBaseUint.__get_pydantic_core_schema__()SSZVector._serialize_data()is implemented similar toSSZList._serialize_data()SSZList._serialize_data()updated to support handlingFpitems (only for consistency)See how they are being used in #193.
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox