refactor(testing): use the shared hex codec in three fixtures - #1159
Merged
tcoratger merged 1 commit intoJun 18, 2026
Merged
Conversation
reaggregation, sync, and api_endpoint hand-rolled the 0x-prefix concatenation while sibling fixtures import to_hex from the shared codec. Replace the occurrences with to_hex. Emitted vectors are byte-identical. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reaggregation.py,sync.py, andapi_endpoint.pyhand-rolled"0x" + x.hex()while sibling fixtures already importto_hexfrom the sharedhex_codec. Replaced the 13 occurrences withto_hex(...).Pure structural refactor —
to_hex(data) == "0x" + data.hex(), so emitted vectors are byte-identical. Found in the packages/testing audit (HEX-CODEC).Lint:
ruff check+ruff formatclean.