Store Raw Response Per Call #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- each call to .call clears out old value & stores the most current raw response in an ivar - raw response is accessible to user via raw_response getter - ensure a string to sent to the logger for debugging the raw_response
alejandroereyes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I'm having to debug & handle rejected emails from sparkpost. Currently the client throws an exception if the response is not successful. While I don't want to change the current behavior and break everyone's integration, I still need access to the response in such a case.
I propose storing each response on a per call basis. This preserves the current behavior and allows anyone to rescue the exception and parse the response as needed.
Changes
client#callclears out any old stored response & stores the most current raw response in an ivarraw_responsegetter