Move logger setup to after MODE selection#126
Open
nickdavies wants to merge 1 commit intoldayton:mainfrom
Open
Move logger setup to after MODE selection#126nickdavies wants to merge 1 commit intoldayton:mainfrom
nickdavies wants to merge 1 commit intoldayton:mainfrom
Conversation
Because we call `setup_logging` before deciding on the mode the log file is always `.claude/hook-approvals.log` even for cursor This split the logger setup in two, first we do basic logging setup with the right format etc so that we don't lose messages related to parsing input and setup and then once we know the mode we are in we call the file logger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we call
setup_loggingbefore deciding on the mode the log file is always.claude/hook-approvals.logeven for cursorThis split the logger setup in two, first we do basic logging setup with the right format etc so that we don't lose messages related to parsing input and setup and then once we know the mode we are in we call the file logger.