Use fnmatch in trailing ' *' fallback for glob patterns#118
Merged
Conversation
The trailing ' *' fallback for bare commands used == instead of fnmatch, so glob characters in the base pattern were not interpreted. e.g. 'tea issue* close *' failed to match bare 'tea issues close'. Guard against degenerate bases (like bare '*') by skipping the fallback when the base pattern matches the empty string. Closes #110
|
Thank you @ldayton ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*fallback (which letspython *match barepython) used==to compare the base pattern against the commandtea issue* close), the==comparison failed because*wasn't interpretedfnmatch()with a guard: skips the fallback when the base pattern matches the empty string (e.g. bare*), preventing* *from matching every commandFixes both
match_commandandmatch_aftercode paths.Closes #110