Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Add Show-MVPProfile #29

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Conversation

JPRuskin
Copy link
Contributor

@JPRuskin JPRuskin commented Oct 12, 2018

Attempts to address #27

A basic function to display MVP profiles in a browser. Defaults to using the output from Get-MVPProfile if no ID is provided, which should result in displaying the current user's profile (though I couldn't test this beyond passing the example files in via the pipeline, as I'm not an MVP - sorry).

Potential issues:

  • No tests (just noticed New feature - Add Unit testing #22)
  • Overstepping in some of the README changes
  • Will likely not work correctly in Core on non-Windows platforms
  • Didn't update the module version
  • Didn't add much validation to the ID parameter

Adds the Show-MVPProfile function to the MVP module. It has basic functionality, and will not currently work well on non-Windows platforms.
Additionally includes some minor corrections, including trying to standardise titles to title case and functions / code to the correct casing.
Copy link
Owner

@lazywinadmin lazywinadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @JPRuskin ! thanks for your help!!!!

@lazywinadmin lazywinadmin merged commit 4ab05b7 into lazywinadmin:master Oct 13, 2018
@JPRuskin JPRuskin deleted the Show-MVPProfile branch October 16, 2018 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants