-
Notifications
You must be signed in to change notification settings - Fork 13
refactor: refactor sdk layer #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
感谢 我晚上看下! |
感谢贡献,有几个问题需要讨论下~ 关于sdk-infrastructure
如果是为了代码复用,能否: a. 简单一点,就把这些代码放在domain包里呢
b. 如果不行的话,改个名字呢, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(如果打字不好沟通的话,可以约个时间视频会议聊 |
@seeflood good idea! 工作日下午怎么样? |
@kevinten10 好呀 明天下午?你看几点合适 |
要不就先暂定明天下午三点或者四点吧~ |
好 |
Iam busy at the end of the year. Give me some time to finish the refactoring~ |
@kevinten10 hi, is this PR ready for review? |
Hi,这里是对原有
runtime-sdk
的改动(不包含reactor),我尽力保持所有类路径和使用方式的不变。layer design
Here is the overall design of the modules:
从
runtime-sdk
中拆分出了sdk-infrastructure
和sdk-domain
模块。sdk-infrastructure:
变更介绍
将
runtime-sdk
中的基础定义类、工具类、属性类等下沉到sdk-infrastructure
层,这将被多种上层实现复用。非兼容的变更点
io.mosn.layotto.v1.domain.ApiProtocol
移动到io.mosn.layotto.v1.value.ApiProtocol
。sdk-domain
包占用,使用value路径sdk-domain:
变更介绍
将标准API的定义剥离到
sdk-domain
层,包括请求响应的实体类、接口定义。独立的API定义模块
sdk-domain
,将有利于:sdk-domain
模块实现dapr
的API。注:
sdk-domain
仅包含同步调用的api,后续reactor模式的api将放在sdk-domain-rx
模块中。变更点
我没有改动原有的API接口和实体类的使用(仅在代码风格上做了统一,以及添加了
toString
这样的方法)。不过我新增了
configuration
的API entities和API接口(接口方法先注释掉了,后续再添加实现)。故和原有API兼容。
grpc
仍在保留在
runtime-sdk
中。