Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inovator badges added #198

Conversation

Jaishree2310
Copy link

@Jaishree2310 Jaishree2310 commented Oct 15, 2023

Description

This PR fixes #4808

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Jaishree2310 <[email protected]>
@Jaishree2310 Jaishree2310 force-pushed the jaishree2310/badge/add-innovator-badge branch from 91f8748 to 78567a5 Compare October 15, 2023 13:55
@abhijeetgauravm
Copy link

Hey @Jaishree2310 Let's discuss this on website call tomorrow at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work. How are you creating SVGs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

  1. Use dual-tone green for person
  2. You can use white for the bulb
  3. The person that you are using is different than what we have in other badges. Take a look at Bring a Buddy, Sharing is Caring, GitOps with Friends badge

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritiksaxena124 there is some issue with the PR. I need to test it once again and will present it in the next meeting.

@ritiksaxena124
Copy link
Contributor

Any update on this @Jaishree2310?

Copy link

github-actions bot commented Dec 9, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@leecalcote
Copy link
Contributor

Pull request abandoned.

@leecalcote leecalcote closed this Jan 6, 2024
@Jaishree2310 Jaishree2310 deleted the jaishree2310/badge/add-innovator-badge branch January 12, 2024 20:00
@Jaishree2310 Jaishree2310 restored the jaishree2310/badge/add-innovator-badge branch January 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants