[components] created searchbar and tooltip
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonette Caldwell <[email protected]>
|
@nebula-aac we should rename the |
Signed-off-by: Antonette Caldwell <[email protected]>
|
This has been updated to rename the directories and the names of the custom components @aabidsofi19 |
|
@aabidsofi19 can you review here again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #72 and #73
In Meshery UI and Meshery Cloud and any others that uses MUI, we have a reusable tooltip but we're duplicating work in this.
For the
search bar, we have this done in Meshery UI but it is not a complete replica of the one from Meshery UI, but it does takes most of the basic properties of what we're using Meshery UI.These two components are also being used in the Design System.
Signed commits