Remove duplicate dependencies @types/lodash #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Amrutiya <[email protected]>
|
@sudhanshutech Could you please review and merge this? |
Nice! Good job on urging for review, @amitamrutiya |
leecalcote
reviewed
Oct 3, 2024
There was a problem hiding this comment.
@amitamrutiya @nebula-aac there needs to be package-lock.json?
sudhanshutech
approved these changes
Oct 3, 2024
sudhanshutech
requested changes
Oct 3, 2024
|
I removed the dependencies written twice so there is already present metadata in the package-lock.json file. So there would be no changes in the package-lock.json file and build as well. We have still @types/lodash. |
sudhanshutech
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits