Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove npm install from build job #729

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove npm install from build job #729

merged 1 commit into from
Sep 17, 2024

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Sep 4, 2024 •
edited by sudhanshutech
Loading

Notes for Reviewers

This PR fixes #505

Signed commits

  • Yes, I signed my commits.

@nebula-aac
Remove npm install from build job
6c2a666 
Signed-off-by: Antonette Caldwell <[email protected]>
@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Sep 4, 2024
@sudhanshutech
Copy link
Member

@nebula-aac good to go?

leecalcote
leecalcote approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit b599e25 into master Sep 17, 2024
8 checks passed
@leecalcote leecalcote deleted the 505-remove-redundant-npm-i branch September 17, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
area/ci Continuous integration | Build and release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Redundant npm install step in release workflow?
3 participants
@nebula-aac @sudhanshutech @leecalcote