Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publish modal schema #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update publish modal schema #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/schemas/publishCatalogItem/schema.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,16 @@ const publishCatalogItemSchema = {
description:
'Specific stipulations to consider and known behaviors to be aware of when using this design.',
format: 'textarea',
'x-rjsf-grid-area': 12
'x-rjsf-grid-area': 12,
"x-encode-in-uri": true
},
pattern_info: {
type: 'string',
title: 'Description',
description: 'Purpose of the design along with its intended and unintended uses.',
format: 'textarea',
'x-rjsf-grid-area': 12
'x-rjsf-grid-area': 12,
"x-encode-in-uri": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 these are native to rjsf right ? . if not where are we documenting these . we should be using a uiSchema and not putting the presentation specific properties in the data structure schema

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @aabidsofi19 we can move it to uiSchema, we are tracking them here - https://github.com/layer5io/sistent/blob/master/src/schemas/readme.md#custom-properties

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in RJSF section in Meshmap developer guide

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops sorry, I mean "Kanvas"

},
type: {
type: 'string',
Expand Down
Loading