-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI]: add a version tag to CatalogCard component #691
Conversation
Signed-off-by: Ankita Sahu <[email protected]>
position: 'absolute', | ||
top: '40px', | ||
right: '8px', | ||
backgroundColor: theme.palette.primary.main, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use color from palette @SAHU-01
Signed-off-by: Ankita Sahu <[email protected]>
position: 'absolute', | ||
bottom: '65px', | ||
left: '18px', | ||
backgroundColor: theme.palette.grey[500], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not these, there is tokens we use you will get those in palette.js file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not these, there is tokens we use you will get those in palette.js file.
Thank you for sharing this, I'll make sure to take a look at it and modify this.
@sudhanshutech based on the Wednesday call feedback that I received, I need to add the flipable thingy and also centralize the catalog card and add on flip all the details that were available on meshery cloud. I'll be done with this over the weekend and will make sure to notify you. |
oh its good. I was tagging @dottharun to confirm does he has any things to confirm here? |
@SAHU-01 Does this support dark mode, and can you provide screenshots if you can? |
@dottharun the tag color doesn't change with dark or light mode switch as of now if you want me to enable that, do let me know |
@SAHU-01 Yes, please use the same shades as the footer. |
@dottharun I did add the version background based on the color palette used for metrics container and it looks something like this: |
Signed-off-by: Ankita Sahu <[email protected]>
@sudhanshutech, I have a couple of questions here:
|
Please find the demo screen here: Screen.Recording.2024-08-05.at.12.03.27.PM.mov |
@SAHU-01 yes the styles should be in separate style folder |
@SAHU-01 If we are using the flip card and showing the version only on the backside, just use the same shades as in https://meshery.layer5.io/. |
any more help needed @SAHU-01 ? |
@sudhanshutech yes, the figma design? Does the gradient and padding look good to you in the recording? If yes I'll push the style file and tag theme changes now? |
Signed-off-by: Ankita Sahu <[email protected]>
the color of metrics in from of card could be shade of white for dark mode. See which looks good from using the token. |
@SAHU-01 have gone through the card here in cloud,: https://meshery.layer5.io/catalog? |
@dottharun @vishalvivekm @captain-Akshay do we have figma design for this card? |
Signed-off-by: Ankita Sahu <[email protected]>
@dottharun, I've removed the flip logic from this PR and I've added the Screen.Recording.2024-08-12.at.5.20.34.PM.mov |
Notes for Reviewers
This PR fixes #688
Signed commits