Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing stories #68

Closed
wants to merge 11 commits into from

Conversation

kunal70006
Copy link
Contributor

@kunal70006 kunal70006 commented Aug 30, 2023

Notes for Reviewers

This PR fixes #60

Components covered

  • Accordion
  • Avatar
  • Backdrop
  • Badge
  • Box
  • ButtonGroup
  • Card
  • Select
  • Dialog

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Kunaldeep singh <[email protected]>
@leecalcote
Copy link
Member

@kunal70006 good stuff

Signed-off-by: Kunaldeep singh <[email protected]>
@kunal70006
Copy link
Contributor Author

I also converted all stories to ts just so we can get more controls and stuff

Signed-off-by: Kunaldeep singh <[email protected]>
@kunal70006 kunal70006 marked this pull request as ready for review August 31, 2023 19:11
@kunal70006
Copy link
Contributor Author

@nebula-aac you can review this one now, i'll update the description to add the list of components that i covered

@nebula-aac nebula-aac self-requested a review August 31, 2023 23:07
@nebula-aac
Copy link
Contributor

okay, ill provide my feedback

Copy link
Contributor

@nebula-aac nebula-aac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunal70006

Here is my review.

Before you get started, update your forked branch to include the latest changes. I opened a PR to include the missing exports from Accordion.

  1. Add these packages to design-system
    "@layer5/sistent-components": "*",
    "@layer5/sistent-svg": "*",

Once you have done this, you will be able to use the packages locally. If it is not does work right away, from the root workspace run yarn build-all in order to build the artifacts. Either way, you still need the two above added to design-system package.

  1. Add tsconfig.json, since you're suggesting to change to Typescript, please make this change the same throughout the entire design-system repo. There are some files that have the .jsx extensions. You can review existing Vite templates that has these config.

Once you have made the above changes, I can review again.

@Ghat0tkach
Copy link
Member

hey @kunal70006
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@kunal70006
Copy link
Contributor Author

hey @Ghat0tkach I think it's already added in the word doc, do I need to do anything else? Also, can you tell me how long the meeting actually lasts because I've a blocker around 6PM IST/7:30AM CST(i think) so I'm only available from 7-7:30 Central

@nebula-aac
Copy link
Contributor

At this time, the design system isn't working for me. I'm creating another PR to convert the entire design system to Typescript from scratch.

@kunal70006
Copy link
Contributor Author

what errors are you facing? do you want to discuss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[storybook] Create missing stories
4 participants