Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback component to use standard style #643

Merged
merged 4 commits into from
Jun 10, 2024

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Jun 6, 2024

Notes for Reviewers

This PR fixes the standard style for feedback component which is standard style for modal
image

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the white text in the button standard for disabled components? No, right?

Copy link
Contributor

@captain-Akshay captain-Akshay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are there @sudhanshutech the success screen in dark mode need a white text.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@leecalcote
Copy link
Member

merge conflict

@sudhanshutech sudhanshutech merged commit db309c1 into layer5io:master Jun 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants