feat(icon): CatalogIcon from Layer5 brand #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leecalcote
reviewed
Jun 5, 2024
dottharun
force-pushed
the
feat/catalogIcon
branch
from
7335532
to
bde6f12
Compare
leecalcote
reviewed
Jun 6, 2024
| }) => { | ||
| const theme = useTheme(); | ||
|
|
||
| const themePrimaryFill = primaryFill ?? (theme.palette.mode === 'dark' ? LIGHT_GRAY : KEPPEL); |
There was a problem hiding this comment.
@nebula-aac is this representative of our approach to light and dark mode support?
Signed-off-by: Tharun T <[email protected]>
Signed-off-by: Tharun T <[email protected]>
dottharun
force-pushed
the
feat/catalogIcon
branch
3 times, most recently
from
5b1be17
to
88e3a01
Compare
- revert previous color changes Signed-off-by: Tharun T <[email protected]>
dottharun
force-pushed
the
feat/catalogIcon
branch
from
88e3a01
to
26cfafb
Compare
leecalcote
approved these changes
Jun 7, 2024
|
LGTM |
1 task
Yashsharma1911
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #632
Screenshots tested in Meshery-UI:
Signed commits