[Tooltip] Update zindex and title display condition #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudraksh Tyagi <[email protected]>
Signed-off-by: Rudraksh Tyagi <[email protected]>
aabidsofi19
requested changes
May 29, 2024
| @@ -39,11 +39,12 @@ function CustomTooltip({ | |||
| }, | |||
| popper: { | |||
| sx: { | |||
| zIndex: 9999999999, | |||
There was a problem hiding this comment.
@dragon-slayer875 why this large of zindex , make zIndex a prop .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
In meshery UI, ziCalc is used to give tooltips a zindex of ziCalc(5), so I instead migrated it here, thus eliminating the need for ziCalc in meshery and meshery cloud.
Moreover, in meshmap many components are given a high zindex which results in the tooltip not displaying properly.
In meshmap, no ziCalc value exceeds ziCalc(9) and thus I have set this value to remedy the problem there too.
The tooltip was also not rendering content which was not in string format making it hard to catch bugs and refactor.
So I updated the condition for title usage.
Signed commits