Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements and fixes in modals #618

Merged
merged 2 commits into from
May 14, 2024
Merged

Enhancements and fixes in modals #618

merged 2 commits into from
May 14, 2024

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented May 13, 2024 •
edited
Loading

Notes for Reviewers

  1. This PR fixes the modals header and background colors.
  2. Adds a check for helperText if its not defined then fix the style of the footer

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
fix(component): modal
91d1a6a 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech
fix(modal): style
abeb156 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@sudhanshutech sudhanshutech mentioned this pull request May 13, 2024
Closed
1 task
@sudhanshutech
Copy link
Member Author

@dragon-slayer875 @captain-Akshay , these are final changes on color based on figma. Please don't change them now

@Yashsharma1911 Yashsharma1911 merged commit 107aa8b into layer5io:master May 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yashsharma1911 Yashsharma1911 Yashsharma1911 approved these changes

@aabidsofi19 aabidsofi19 Awaiting requested review from aabidsofi19

@nebula-aac nebula-aac Awaiting requested review from nebula-aac

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudhanshutech @Yashsharma1911